Sync C# cubic interpolation with core #64860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
force-pushed
the
dotnet/sync-math
branch
from
97452d0 to
b2479ba
Compare
neikeq
approved these changes
Aug 27, 2022
Depends how much the non-generated C# documentation follows the core documentation. If the summary tends to be the same, then it may be worth waiting for the core one to be documented first. |
raulsntos
force-pushed
the
dotnet/sync-math
branch
from
b2479ba to
f64b845
Compare
It tends to be the same, at least for these interpolation methods. |
|
Thanks! |
MewPurPur
pushed a commit
to MewPurPur/godot
that referenced
this pull request
Aug 27, 2022
Sync C# cubic interpolation with core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the C# implementation of cubic interpolation methods (mostly in Quaternion) with the latest changes implemented in core to keep C# in sync.
Included changes
Quaternion.SlerpniTransform3Dinterpolation and add spherical interpolation (Follow up to Fixed someTransform3DGizmobehavior to make more consistent #53684)GetAngleandGetAxisto Quaternion (Follow up to Implement animation compression #54050 and Fix blend animation to solve TRS track bug & blend order inconsistency #57675)ExpandLogto Quaternion (Follow up to Fix blend animation to solve TRS track bug & blend order inconsistency #57675 and Fix Quaternion Tween and add Easing baker to AnimationTrackEditor #64678)Quaternion.CubicSlerp(Follow up to Fixcubic_slerp()#63380)Quaternion.SphericalCubicInterpolate(Follow up to Rename and unify notation for spherical interpolation #63532 and Makespherical_cubic_interpolate()more stable #63593)CubicInterpolateInTime(Follow up to Makecubic_interpolate()consider key time in animation #63602)CubicInterpolateAngle(Follow up to Add linear/cubic angle interpolation toAnimation::InterpolationTypefor shortest 2D rotation #64924)I made separate commits for each core PR but I can squash them if that's not useful.
TODO